From: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
Date: Wed, 3 Jul 2019 17:53:09 +0000 (-0300)
Subject: controlsManager: Don't fade icon grid while dragging
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~839^2^2~21
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e45c9178116bda103dbdf9626ced0a4343334471;p=gnome-shell.git

controlsManager: Don't fade icon grid while dragging

As pointed out by designers, fading it signals that the
icon grid is not a drop target, when now it actually is.

Remove the fade effect applied to the icon grid when
dragging. Since this is the only caller of fadeIn() and
fadeHalf(), also remove these methods.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/664
---

diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js
index c9f9872c8..cf24a5e56 100644
--- a/js/ui/overviewControls.js
+++ b/js/ui/overviewControls.js
@@ -447,17 +447,6 @@ var ControlsManager = class {
         layout.connect('allocation-changed', this._updateWorkspacesGeometry.bind(this));
 
         Main.overview.connect('showing', this._updateSpacerVisibility.bind(this));
-        Main.overview.connect('item-drag-begin', () => {
-            let activePage = this.viewSelector.getActivePage();
-            if (activePage != ViewSelector.ViewPage.WINDOWS)
-                this.viewSelector.fadeHalf();
-        });
-        Main.overview.connect('item-drag-end', () => {
-            this.viewSelector.fadeIn();
-        });
-        Main.overview.connect('item-drag-cancelled', () => {
-            this.viewSelector.fadeIn();
-        });
     }
 
     _updateWorkspacesGeometry() {
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 9aef3b9dd..c4201239e 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -599,23 +599,5 @@ var ViewSelector = class {
         else
             return ViewPage.SEARCH;
     }
-
-    fadeIn() {
-        let actor = this._activePage;
-        actor.ease({
-            opacity: 255,
-            duration: OverviewControls.SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_IN_QUAD
-        });
-    }
-
-    fadeHalf() {
-        let actor = this._activePage;
-        actor.ease({
-            opacity: 128,
-            duration: OverviewControls.SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_OUT_QUAD
-        });
-    }
 };
 Signals.addSignalMethods(ViewSelector.prototype);